Attention is currently required from: Daniel Campello, Edward O'Callaghan, Nico Huber, Peter Marheine, Richard Hughes.

View Change

1 comment:

• File tests/chip.c:

  • Patch Set #6, Line 86: struct progress_user_data *progress_user_data = progress_state->user_data;

     Redefining the callback would be ideal (void(flashrom_progress_callback)(enum flashrom_progress stage, size_t, size_t, void*)) instead

    I am thinking, what if we actually do this, redefine the callback in the right way?

    I know it's changing the API, but, I am not sure who was using the API: without this patch it wasn't possible to use anyway?
    As of, I specifically mean using progress API in libflashrom, it wasn't possible without locally applied patch(es), like this one for example. So if we make this change now, but then it will be possible to use progress in libflashrom at head, maybe it's not that bad?

    (there are lots of cli users, I know, but cli users not affected anyway)

To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.