View Change
2 comments:
File spi25.c:
Patch Set #2, Line 524: 0xdb
I looked for it and it didn't grep in spi.h so I left it for now.
Ack
Patch Set #2, Line 634: return &spi_block_erase_dc;
I thought about it but figured its sort of easier to read with the magics but I wasn't sure so I lef […]
I think this would look much better if using an array of structs with function pointers. I'll take a look later.
To view, visit change 47005. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1876781672fe03302af4a6ff8d365f2e6c3b6f13
Gerrit-Change-Number: 47005
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 30 Oct 2020 10:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment