Attention is currently required from: Thomas Heijligen, Evan Benn.
7 comments:
Commit Message:
Patch Set #1, Line 7: Add unmock_io.c
Redirect to real I/O to support coverage run
Add functions and a struct that defer the io functions mocked by
mock_io to the real implementations.
Implement a check that redirects mock io functions to the real implementations. Real I/O functions are needed for the coverage tool to be able to create and write files.
Patch Set #1, Line 10: This is to support code coverage.
remove
File tests/unmock_io.c:
Patch Set #1, Line 19: unmock_io
How about `io_real.h` (and `io_real.c`)? this aligns with `io_mock` that we already have.
Function names are all fine, I am specifically about file names
Patch Set #1, Line 25: (void)state;
Just drop this line, none other custom mocks are using it.
This line is used in test methods (there are none in this file).
// Mock ios that defer to the real io functions.
// These exist so that code coverage can print to real files on disk.
Please format the comment as /* */ and same below
Patch Set #1, Line 61: maybe_unmock_io
Let's add a comment for this function:
Detects a coverage run and registers real I/O functions instead of mocks so that coverage tools can create and write real files and generate a coverage report.
To view, visit change 69539. To unsubscribe, or for help writing mail filters, visit settings.