Nico Huber has uploaded this change for review.
ich_descriptors: Use MAX_NUM_FLREGS for entries[]
5 regions made sense in 2013 when this bit of code was originally
written. MAX_NUM_FLREGS is now used to keep track of the max number of
flash regions and is >5 since Sunrise Point.
Original-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38
Original-Reviewed-on: https://review.coreboot.org/21338
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Nico Huber <nico.h@gmx.de>
Change-Id: Ic6b658a1625620009ffd23e526093609a6b0baf8
Signed-off-by: David Hendricks <dhendricks@fb.com>
---
M ich_descriptors.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/21821/1
diff --git a/ich_descriptors.h b/ich_descriptors.h
index 9a16031..db4d28f 100644
--- a/ich_descriptors.h
+++ b/ich_descriptors.h
@@ -568,7 +568,7 @@
struct ich_layout {
struct flashrom_layout base;
- struct romentry entries[5];
+ struct romentry entries[MAX_NUM_FLREGS];
};
ssize_t ich_number_of_regions(enum ich_chipset cs, const struct ich_desc_content *content);
To view, visit change 21821. To unsubscribe, visit settings.