View Change

3 comments:

• Commit Message:

  • Patch Set #3, Line 16: TEST=test

    Was a test actually performed?

    e.g.,

    `TEST=flash image, then read it back then erased successfully.`

    Also no need to indent the commit message. For an example of a commit message format see https://review.coreboot.org/c/flashrom/+/44073

• File flashchips.h:

  • Patch Set #1, Line 814:

    two tabs needed to line up with the rest from the looks of it.

    Click "Resolve" on comments that were fixed.

• File flashchips.c:

  • Patch Set #1, Line 19004: TEST_OK_PREW

    Were these all tested? if not then you want `TEST_UNTESTED`. […]

    I feel like the `TEST=` line should indicate these were not actually tested from the sounds of things. So in the commit message `TEST=builds` and for each chip `.tested = TEST_UNTESTED`.

To view, visit change 48949. To unsubscribe, or for help writing mail filters, visit settings.