Attention is currently required from: Felix Singer, Thomas Heijligen, Evan Benn.

View Change

15 comments:

• File tests/selfcheck.c:

  • Patch Set #7, Line 40: programmer row

    programmer entry

  • Patch Set #7, Line 68:

    assert_table(chip->bustype != BUS_NONE, "chip bustype is BUS_NONE", i,
    			     chip->name);
    

    make one line

  • Patch Set #7, Line 74: {

    You can add `(void)state; /* unused */` in the beginning here. And don't forget new line after :)

  • Patch Set #7, Line 87:

    				/* Blocks with zero size are bugs in flashchips.c. */
    				/* Blocks with zero size are bugs in flashchips.c. */
    

    Same line repeats twice?

  • Patch Set #7, Line 89:

    				if (eraser.eraseblocks[i].count
    				    && !eraser.eraseblocks[i].size) {
    

    make if condition on one line

  • Patch Set #7, Line 91:

    					fail_msg(
    						"Flash chip %s erase function "
    						"%zu region %zu has size 0",
    

    make one line (out of 91-93)

  • Patch Set #7, Line 97:

    				if (!eraser.eraseblocks[i].count
    				    && eraser.eraseblocks[i].size) {
    

    make if condition on one line

  • Patch Set #7, Line 99:

    					fail_msg(
    						"Flash chip %s erase function "
    						"%zu region %zu has count 0",
    

    make one line (out of 99-101)

  • Patch Set #7, Line 135:

    remove empty new line

  • Patch Set #7, Line 136:

    					fail_msg(
    						"Flash chip %s erase function "
    						"%zu and %zu are identical.",
    

    make one line (out of 136-138)

  • Patch Set #7, Line 143:

    				fail_msg(
    					"Flash chip %s erase function %zu is not "
    					"in order",
    

    make one line (out of 143-145)

  • Patch Set #7, Line 170:

    			fail_msg("Board enable for %s %s is misdefined.\n", b->vendor_name,
    				 b->board_name);
    

    make one line

• File tests/tests.h:

  • Patch Set #7, Line 90: _tables

    The file name is `selfcheck.c` without `_tables` suffix

• File tests/well_formed_tables.c:

  • Patch Set #6, Line 24:

    	do {                                                                                   \
    		if (!(assertion))                                                              \
    			fail_msg(#assertion " is false for index:%zu name:%s", (index),        \
    				 (name) ? (name) : "unknown");                                 \
    	} while (0)
    

    I agree that would be the preferred style but a macro is used so that the __LINE__ format used by fa […]

    Having correct __LINE__ is important, helps a lot with debugging tests. So I am happy to keep as it is. Felix would you agree?

  • Patch Set #6, Line 83: SKIP_TEST

    Done

    not done :P

To view, visit change 69620. To unsubscribe, or for help writing mail filters, visit settings.