Attention is currently required from: Xiang Wang, Stefan Reinauer.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: helpers.c: optimize strndup
Thanks a bunch for the rewrite Angel, I couldn't understand the initial msg either and was going to […]
About adding a unit-test for this function: Maybe, but it is only used for MinGW. Moreover, I doubt unit-tests can catch undefined behavior. I don't mind if someone writes a unit-test for it, but I think there's better candidates for unit-testing.
To view, visit change 49741. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id34127024085879228626fbad59af03268ec5255
Gerrit-Change-Number: 49741
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang <merle@hardenedlinux.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Shawn C <citypw@hardenedlinux.org>
Gerrit-Attention: Xiang Wang <merle@hardenedlinux.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Wed, 20 Jan 2021 15:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang <merle@hardenedlinux.org>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment