Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
View Change
1 comment:
File flashchips.c:
Patch Set #2, Line 22495: FEATURE_4BA_ENTER_WREN
Does enter/exit 4-byte mode depend on WREN? Or can it be done without WREN? […]
Since 256Mb or more requires 4 bytes for addressing, the enter/exit 4-byte address mode operation is required.
XMC has defined enter/exit 4-byte address mode without WREN (06h) command in the SFDP table of 256Mb+ capacity Datasheet.
We don't need to add WREN (06h) command before enter/exit 4-byte address mode, but it's OK to add WREN (06h) command or no WREN (06h) command in front of it, it won't affect.
To view, visit change 83243. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I251c66b5d3b4fc94242c2c9d6b7c0f03c1bd7d0b
Gerrit-Change-Number: 83243
Gerrit-PatchSet: 4
Gerrit-Owner: Ssunk <ssunkkan@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 15:01:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>