Stefan Tauner posted comments on this change.

View Change

Patch set 1:

I have a strong preference, indeed. But I can't force anybody as
there
is no written rule. My general impression is: When somebody makes
the
visible width (end minus indentation) of a text block wider than 80
chars, he doesn't care if somebody will read it. If he makes it
wider
than 100 chars, he doesn't want it to be read.

The typesetting rule is to break around 60~70 chars (going back to
typesetting research done some centuries ago, iirc).

I don't really disagree with you on the readability of shorter lines in general... I write almost everything I publish for others to read in Latex-based PDFs for a reason after all ;)
However, the cited 60-70 cpl are for continuous justified text printed out on paper. For source code where fixed-point fonts are used in very short paragraphs these results are not necessarily true and there are studies that disprove the theory that e.g. 100 cpl is less legible than shorter lines on average when reading from screens as well.

That said, I would not mind a shorter maximum length of comment lines if we agree on some rule (e.g. 75 cpl hard limit) although it would be a bit of a nuisance to comply with that (I know of no editor that provides such an dynamic guide easily). If you want such a rule please post a mail on the mailing list with your proposition so that others can chime in and we have something to refer to in the future if a consensus is reached. Until then I will continue using the space to the maximum column limit of 112.

With the help of git hooks we might check for these things automatically though... if someone wants to hack on that ;)

To view, visit change 21825. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4021be49a9fab208b619c555b9f9e81f671ab8
Gerrit-Change-Number: 21825
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 04 Oct 2017 00:05:21 +0000
Gerrit-HasComments: No