Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 7: endian: Decide __FLASHROM_XXX_ENDIAN__ in the buildsystem
I would rewrite that. How about this? […]
I just noticed that the `ENDIAN` variable is set at line 268. So it's not a built-in function. I would replace `built-in` with `existing`.
To view, visit change 58273. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d
Gerrit-Change-Number: 58273
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 19:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Gerrit-MessageType: comment