Attention is currently required from: Stefan Reinauer, Edward O'Callaghan.
Patch set 2:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #2, Line 29: printf("%d\n", *foo.b);
In C, dereferencing a null pointer is undefined behavior. I'm not sure what the purpose of this code snippet is. If it's to show the problems of non-null but invalid pointers, I'd use pointers to functions with different signatures.
Still, I believe this change is a good idea: it's better to have null pointers than non-null but invalid pointers.
To view, visit change 50246. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I576967a8599b923c902e39f177f39146291cc242
Gerrit-Change-Number: 50246
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Wed, 03 Feb 2021 11:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment