Nico Huber posted comments on this change.
Patch set 2:
Please revise the comment in the header file. Looks good, otherwise.
Added in the header file. The code was already checking for validity of 'pa
Yes, the code was and is still checking the `pacc` pointer in
the shutdown handler, which is nuts IMHO. It has nothing to
say about the sanity of the program as the pointer is not used
`pacc` is only interesting for the pci_get_dev() call.
That's not accurate... how about:
To clone the pci_dev instances internally, the `pacc` global
variable has to reference a pci_access method that is compatible
with the given pci_dev handle. The referenced pci_access (not
the variable) has to stay valid until the shutdown handlers are
To view, visit change 20784. To unsubscribe, visit settings.