Nico Huber posted comments on this change.

View Change

Patch set 2:

Please revise the comment in the header file. Looks good, otherwise.

(2 comments)

• File pcidev.c:

  • Patch Set #1, Line 297: }

    Added in the header file. The code was already checking for validity of 'pa

    Yes, the code was and is still checking the `pacc` pointer in
    the shutdown handler, which is nuts IMHO. It has nothing to
    say about the sanity of the program as the pointer is not used
    anymore.

    `pacc` is only interesting for the pci_get_dev() call.

• File programmer.h:

  • Patch Set #2, Line 200: */

    That's not accurate... how about:

        To clone the pci_dev instances internally, the `pacc` global
        variable has to reference a pci_access method that is compatible
        with the given pci_dev handle. The referenced pci_access (not
        the variable) has to stay valid until the shutdown handlers are
        finished.

To view, visit change 20784. To unsubscribe, visit settings.