Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

Patch set 5:Code-Review +2

View Change

4 comments:

• File flashrom.c:

  • Patch Set #3, Line 1716: programmer_table_size != PROGRAMMER_INVALID

    Now after I read the whole chain of commits, this doesn't matter anymore.

    The answer is in the way how the enum was declared, with all the #if. It made
    PROGRAMMER_INVALID reflect the number of _valid_ programmers. This number
    is constant, no matter if there is a terminating, invalid entry.

• File print_wiki.c:

  • Patch Set #3, Line 403: *prog

    This is what I meant with "and below", apparently.

  • Patch Set #3, Line 415: *prog

    and this

  • Patch Set #3, Line 429: *prog

    and this

    Actually, in loops that don't need an index, we could also use a pointer
    as iterator, e.g.

        const struct programmer_entry *prog;
        for (prog = programmer_table; prog < programmer_table + PROGRAMMER_INVALID; ++prog)

    Though, that's not what people are used to, I assume.

To view, visit change 52945. To unsubscribe, or for help writing mail filters, visit settings.