Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

View Change

18 comments:

• Patchset:

  • Patch Set #5:

    I added many cleanups you can do as a follow up patch to make type usage consistent, const correct a […]

    Thank you! I've marked them as resolved, because they are not the part of this patch.

• File ch341a_spi.c:

  • Patch Set #3, Line 80:

    	struct libusb_transfer *transfer_out;
    	struct libusb_transfer *transfer_ins[USB_IN_TRANSFERS];
    
    	/* Accumulate delays to be plucked between CS deassertion and CS assertions. */
    	unsigned int stored_delay_us;
    
    	struct libusb_device_handle *handle;
    

    I recommend putting the handle at the start of the struct so that overflows in the above transfer bu […]

    Done

  • Patch Set #3, Line 100: i = 0

    `size_t i = 0;`

    Ack

  • Patch Set #3, Line 234: unsigned int i;

    delete

    Ack

  • Patch Set #3, Line 235: i

    probably should be `size_t i = 0;`

    Ack

  • Patch Set #3, Line 268: uint8_t

    `const`?

    Ack

  • Patch Set #3, Line 311: stored_delay_us

    `delay_us`

    Ack

  • Patch Set #3, Line 315: int

    `unsigned int` ?

    Ack

  • Patch Set #3, Line 323: i = 0

    `unsigned int i = 0;`

    Ack

  • Patch Set #3, Line 365: nsigned int p;

    delete

    Ack

  • Patch Set #3, Line 366: p

    actually should be `size_t p = 0;`

    Ack

  • Patch Set #3, Line 387: i

    `unsigned int i`

    Ack

  • Patch Set #3, Line 419: 4 * 1024

    `4*KiB` in another patch?

    Ack

  • Patch Set #3, Line 460: ret != 0

    `ret`, C will auto-cast to make the predicate boolean.

    Ack

  • Patch Set #3, Line 465: (ret != 0)

    `(ret)` is canonical.

    Ack

  • Patch Set #3, Line 495: i

    `int i` in another patch?

    Ack

  • Patch Set #3, Line 504: i = 0

    ditto

    Ack

  • Patch Set #3, Line 513: i = 0

    ditto

    Ack

To view, visit change 72807. To unsubscribe, or for help writing mail filters, visit settings.