Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.

6 comments:

Commit Message:

Patch Set #4, Line 10:
```
 This is an important step to
remove the global state because it'll allow the programmer's data
to be used in delay functions.
```
Maybe just drop part of this sentence after 'because' as its not what this patch does specifically f […]
Sure!

Patch Set #4, Line 13:


Programmers that use internal delay can provide NULL as a context.

Move this up to the last paragraph.

Done

Patch Set #4, Line 16:

This is one of the steps on the way to move master's data
memory management behind the initialisation API, for more
context see other patches under the same topic specified below.

Drop this paragraph.

Done

Patchset:
- Patch Set #4:
  Can we rebase this one and have it go in? […]
  Done
File flashrom.c:
- Patch Set #5, Line 220: void programmer_delay(const struct flashctx *flash, unsigned int usecs)
  Is it OK that I've refactored this function in this patch? Because otherwise there would be lots of nested if-statements.
File flashrom.c:
- Patch Set #6, Line 226: return internal_delay(flash, usecs);
  Since we don't use `internal_delay` as a callback, we may not provide `flashctx`. It will be more meaningful, just `internal_delay(usecs)`.
  What do you think?

To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.