View Change

3 comments:

• File cli_classic.c:

  • Patch Set #17, Line 57: --fmap <fmapfile> read ROM layout from binary containing <fmapfile>"

    needs to be updated.

    Nice catch - done.

• File libflashrom.c:

  • Patch Set #18, Line 462:

    		for (offset = 0;
    		     offse
    

    This does two things:

    • Makes the stride fall within the length passed into the function.
    • Makes the stride align with block boundaries on the chip.

    We could also try setting the stride based on rom_offset and len, e.g. 'stride = log2(len) / 2' in the loop initialization, but that requires adding -lm to link options or implementing our own log2().

  • Patch Set #18, Line 479: break;

    Updated to use rom_offset + len instead of chip_size to enforce the boundaries passed into the function.

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.