Attention is currently required from: Edward O'Callaghan, Light, Anastasia Klimchuk.
View Change
1 comment:
File pony_spi.c:
Patch Set #3, Line 167: bool have_device;
A bit of nit isn't it? Is there a solid technical reason here or just personal preference?
From my point of view: Review doesn't scale well with the size of
a patch. Even if it's a very simple patch hunk, every additional
hunk can distract from the error-prone part of a patch. Doing fixes
and simple changes like this in advance works well, FWIW.
To view, visit change 63130. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I364febc05c870683cbad114583762b0c006f4bac
Gerrit-Change-Number: 63130
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Sat, 02 Apr 2022 14:19:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment