Attention is currently required from: Robert Zieba, Paul Menzel, Jon Murphy, Edward O'Callaghan, Felix Held.
View Change
3 comments:
Commit Message:
Patch Set #1, Line 11: generation
generations?
Done
Patch Set #1, Line 8:
Flashrom has been using legacy spi100 bit mappings when programming the
opcode and triggering the command. These legacy bit mappings are
deprecated in upcoming generation of AMD SoCs.
The knowledge of how SPI100 works completely is spare, can you provide more precise details here?
Added more details relevant to this CL. Also added the reference document number (for Cezanne SoC) which has some details about SPI100.
Patch Set #1, Line 11:
Stop using the legacy
spi100 registers and use the correct ones.
Ran on Cezanne and everything looks good […]
Done
To view, visit change 63422. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If42130757331f4294b5a42c848557d3287f24fc3
Gerrit-Change-Number: 63422
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Robert Zieba <robertzieba@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jon Murphy <jpmurphy@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Thu, 07 Apr 2022 18:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba <robertzieba@google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment