Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
View Change
1 comment:
File flashchips.c:
Patch Set #1, Line 22696: TEST_UNTESTED
The existing entry for XM25QU64C was untested, and if two models share the same definition, they also share test status. So the new model would also be marked "untested" even though you actually tested it.
Is it possible that you test XM25QU64C (the one that was here before)? Then you will be able to mark them both as tested.
If you do that, you will then add in commit message the info that you tested both models.
Thank you!
To view, visit change 84775. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7
Gerrit-Change-Number: 84775
Gerrit-PatchSet: 1
Gerrit-Owner: Ssunk <ssunkkan@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Ssunk <ssunkkan@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Thu, 17 Oct 2024 07:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No