Nico Huber merged this change.

View Change

Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
internal: Fix warnings about unused constants

By adding more #if guards, fix warnings about unused constants that
are enabled by default in newer GCC versions.

Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/22669
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
---
M internal.c
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/internal.c b/internal.c
index 4062b64..276e14b 100644
--- a/internal.c
+++ b/internal.c
@@ -131,6 +131,7 @@
int is_laptop = 0;
int laptop_ok = 0;

+#if IS_X86 || IS_MIPS
static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
chipaddr addr);
static void internal_chip_writew(const struct flashctx *flash, uint16_t val,
@@ -155,6 +156,7 @@
.chip_writel = internal_chip_writel,
.chip_writen = fallback_chip_writen,
};
+#endif

enum chipbustype internal_buses_supported = BUS_NONE;

@@ -358,6 +360,7 @@
}
#endif

+#if IS_X86 || IS_MIPS
static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
chipaddr addr)
{
@@ -400,3 +403,4 @@
mmio_readn((void *)addr, buf, len);
return;
}
+#endif

To view, visit change 22669. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919
Gerrit-Change-Number: 22669
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>