Attention is currently required from: Xiang Wang, Stefan Reinauer, Edward O'Callaghan.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: helpers.c: optimize strndup

    An optimization? Really?

    This change fixes potential undefined behavior. So, I'd rewrite the commit message as follows:

     helpers.c: Fix undefined behavior in strndup()
     
     Using strlen() or strdup() inside strndup() is problematic: if the input string is not null-terminated, these functions can read past the end of the buffer, which triggers undefined behavior. Rewrite the function to never read past the provided `maxlen` bound.

  • Patch Set #1, Line 10: has no feedback for a long time

    This is just one of the possible outcomes of undefined behavior. It could also result in a segmentation fault, or start reading registers from a MMIO window, or something else I didn't think of.

To view, visit change 49741. To unsubscribe, or for help writing mail filters, visit settings.