Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File sysfsgpio.c:
Patch Set #1, Line 209:
/* parameter format: pins=cs_pin:sck_pin:mosi_pin:miso_pin */
char *pins = extract_programmer_param("pins");
int pins_inited = 0;
do {
struct pin_desc *pins_tab[] = {
&pin_cs, &pin_sck, &pin_mosi, &pin_miso
};
if (!(pins && strlen(pins)))
break;
char *token = strtok(pins, ":");
for (unsigned i = 0; i < ARRAY_SIZE(pins_tab); i++) {
long v;
if (!token)
break;
if (atoi_s(token, 1, &v))
break;
pins_tab[i]->pin = v;
if (export_sysfsgpio(pins_tab[i]))
break;
token = strtok(NULL, ":");
pins_inited = (i + 1 == ARRAY_SIZE(pins_tab));
}
} while (0);
if (pins)
free(pins);
if (!pins_inited)
return 1;
It looks much better now but I think we can make one more step forwards to keeping more of the funct […]
Done
To view, visit change 49254. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1bc47ef8011bba560326b501a80869340bb9f733
Gerrit-Change-Number: 49254
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Wang <merle@hardenedlinux.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Shawn C <citypw@hardenedlinux.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 10 Jan 2021 03:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang <merle@hardenedlinux.org>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment