Patch Set 1: Code-Review+2

(1 comment)

Hi, welcome and thanks for sending this change!

Looks pretty good, just a minor suggestion about the commit summary (which you can easily address with the gerrit web interface).

Patch Set 1: Code-Review+1

I see that your one of the maintainer of flashrom, I request for a review for addition of this flash type.

Usually, giving code-review scores to one's own changes is discouraged (the idea is that others review and give a score to your change). But as this is your first change in gerrit, I understand it's just a rookie mistake, no big deal :)

Point noted. Usually some projects request a +1 as a way of communicating the change was tested locally with hardware :)

View Change

To view, visit change 34234. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I964e630197e33d69b199fdfb8816f18e3112bbb1
Gerrit-Change-Number: 34234
Gerrit-PatchSet: 2
Gerrit-Owner: Hemanth Guruva Reddy
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Hemanth Guruva Reddy
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sean Nelson <audiohacked@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 16 Jul 2019 11:16:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment