Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons.

2 comments:

Patchset:
- Patch Set #4:
  cmocka offers a function TO skip a test. this would make clear, that nothing was executed. […]
  This is a great idea, thank you so much! I decided to use this idea straight away. This is indeed more correct to skip the test vs running empty.
  Also I now realised that thanks to your work on programmer enum, log message is saying "Testing programmer_init for programmer=linux_spi ..." instead of "Testing programmer_init for programmer=24 ...", so nice :)
File tests/init_shutdown.c:
- Patch Set #1, Line 35:
```
#if CONFIG_DUMMY == 1
void dummy_init_and_shutdown_test_success(void **state)
{
	run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
}
#endif /* CONFIG_DUMMY */
```
  > "yes"/"no" is only used on the user end. Both Meson and the Makefile always use […]
  This is a work of art! I evaluated it step by step on a piece of paper, but wow to someone who wrote this :)
  Generally, yes, that's very cool!
  But for tests, I recently realised that for some tests more guards are needed, not just checking CONFIG_xxx. For example ene_lpc the whole file is guarded by `#if defined(__i386__) || defined(__x86_64__)` and my understanding test should copy the same.

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.