Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File programmer.h:
Patch Set #1, Line 228: enable_flash_xxx
Anastasia, have you seen this thread?
Thank you Angel! reading it again, I thought it was about _xxx only but missed the last paragraphs, I am sorry :\ I saw that _xxx is removed from the latest version and thought that's it.
Ok, I understand that "enable" is already present in the struct name "penable", so doesn't need to be repeated. Also yes for command pattern, although in other places we have commands with the name of the action, like chip has read/write/unlock, masters also have read/write_256, programmers have init etc. Maybe enable or do_enable?
To view, visit change 52364. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b3a4ec51ea488c40c20ccafea883f8dea93577d
Gerrit-Change-Number: 52364
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 20:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment