3 comments:

File it85spi.c:
- Patch Set #3, Line 310: }
``` […]
Is else needed here ? if condition returns, so without else it is the same effect.
I added else, because maybe it is needed for readability purposes? Tell me if I need to remove.
- Patch Set #3, Line 342:
```
ce_high = (unsigned char *)(base + 0xE00);  /* 0xFFFFFE00 */
	ce_low = (unsigned char *)(base + 0xD00);  /* 0xFFFFFD00 */
```
  looks like you can just fold these into the below initialisation. […]
  wow yes ! this is looking so nicer
- Patch Set #3, Line 362: msg_pdbg("Registering IT85 SPI.\n");
  remove
  Done

To view, visit change 48196. To unsubscribe, or for help writing mail filters, visit settings.