Attention is currently required from: Angel Pons.
View Change
1 comment:
Patchset:
Patch Set #1:
On the first view, still from a mobile device, I like this patch.
what do you think of creating an const instance of ft2232_parameters with the default values instead of passing them in the code? So you have `struct ft2232_parameters programmer_parameters = ft2232_default_parameters;`
To view, visit change 67908. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25faac1060fc2bcd6042e34802e5bc493c936377
Gerrit-Change-Number: 67908
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 02 Oct 2022 06:21:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment