Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

5 comments:

Patchset:
- Patch Set #2:
  I split this into 5 patches, and first three are ready, these ones: […]
  And now all 5 patches are ready.
Patchset:
- Patch Set #6:
  thank you for reviews!
File hwaccess_io_unittest.h:
- Patch Set #2:
  Move into `tests/`?
  This file is referenced in meson.build in root directory (and the same situation is with unittest_env.h) and I am worried that root build file would depend on the file in tests/ (other way around is normal, tests depend on root).
  What do you think about it? If you say this is fine, I can move into tests/
- Patch Set #2, Line 24: #ifndef __HWACCESS_IO_H__
  Maybe leave a comment that we intentionally use the same guard.
  Done
File tests/meson.build:
- Patch Set #2, Line 36:
```
  '-Wl,--wrap=test_outb',
  '-Wl,--wrap=test_inb',
  '-Wl,--wrap=test_outw',
  '-Wl,--wrap=test_inw',
  '-Wl,--wrap=test_outl',
  '-Wl,--wrap=test_inl',
```
  I guess as these are not implemented anywhere, we don't need to "wrap" […]
  I would prefer to have everything as wraps, then from the point of view of someone working on tests all wraps are the same, they all can return mock() etc etc.
  If half of functions is wraps, and other half is test_ then for someone not familiar the question is: what is the difference? But there is no difference.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.