Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
View Change
1 comment:
File raiden_debug_spi.c:
Patch Set #2, Line 1404:
free(ctx_data);
free(spi_config);
Something I just thought right now: do I need to swap these two lines? (same for another branch in this function, and same for init function).
I thought yes, and then I thought no it's not needed: spi_config is independent pointer and it won't disappear after free(ctx_data)?
Just wanted to check that it is indeed not needed?
To view, visit change 57972. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5400802aa6961538df12fcd5339f7e2a5db145a1
Gerrit-Change-Number: 57972
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 05 Oct 2021 00:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment