Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.

View Change

3 comments:

• File flash.h:

  • Patch Set #5, Line 268: struct flashrom_layout *default_layout;

    Is single_layout used anywhere else? I see that struct ich_layout is deleted in this patch, but comm […]

    Removed, thanks for spotting!

• File layout.c:

  • Patch Set #2, Line 284: out of memory.

    That would be implementation specific. I don't think the libflashrom […]

    Ping?

• File layout.c:

  • Patch Set #5, Line 397: malloc

    use calloc as it will always zero the heap.

    Can you elaborate why it would be useful in this case?

To view, visit change 33543. To unsubscribe, or for help writing mail filters, visit settings.