Attention is currently required from: Michał Żygowski, Angel Pons.
View Change
1 comment:
File ich_descriptors.c:
Patch Set #1, Line 955: CHIPSET_300_SERIES_CANNON_POINT
I also have a suggestion: we could reuse the coreboot's ifdtool detection function guess_ifd_2_chips […]
It's certainly possible if you want to pursue this. However, ifdtool
was often unreliable in the past. And that function is using strap
settings and not structural fields like we are used to. I'm not sure
how well that works and it would need some more restructuring of
the code here to access strap information.
To view, visit change 55577. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib61d432ab4eaf00aa4eef50d2844940e73b5cad6
Gerrit-Change-Number: 55577
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 18 Jun 2021 15:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski@3mdeb.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment