Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons, Sergii Dmytruk.
Patch set 37:Code-Review +2
2 comments:
File dummyflasher.c:
Patch Set #34, Line 169: assert
Returned assert() keeping the function generic and added a comment as to why it's there.
Wow thanks so everyone much for discussion, that's great!
My original question is answered in full. I am marking comment as resolved.
File flashrom.8.tmpl:
is a hexadecimal value of up to 24 bits. For example, 0x332211 assigns 0x11 to
SR1, 0x22 to SR2 and 0x33 to SR3. Shorter value is padded to 24 bits with
zeroes on the left. See datasheet for chosen chip for details about the
registers content.
This is awkward but the comment below I typed yesterday and forgot to send... discovered it today as a saved draft :D It was meant to explain the comment in the next patch. Sorry!
However you still resolved everything, thank you!
I looked into the next patch in the chain CB:59073 and I see this would be better in CB:59073. So my comment is the same, just for the next patch. Sorry for confusion.
To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.