Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.
3 comments:
Commit Message:
Patch Set #2, Line 10: files and tests.
Nit. If these are paragraphs, split them with empty lines. If they […]
done
Patchset:
> > 1) There are two different headers for a file under test and for a test (unittest_env. […]
Nico, sorry for a delay, I just needed some time to think about it.
I really like the idea and want to do this, because it “leaves the code untouched” as you said. That would cover all the files implicitly, which is great: no need to add unittest_env.h in every file and what is even better all new future files are covered as well.
Now I am trying to get a clear idea how exactly to implement this, so reading meson manual etc, definitely working on this.
Let’s check my understanding:
1) I need to create another target in root (not test) meson.build, so that will be two targets: one for “real env”, one for “test env”? And then tests/meson.build will use that second “test env” target?
2) And “real env” target leaves includes as is, while “test env” target adds stdlib.h and unittest_env.h?
3) The last bit: tests/meson.build includes unittest.h in every test?
I am resolving two other comments, just leaving remaining hard one, but I am working on it!
File tests/flashrom.c:
Patch Set #2, Line 27: #define assert_string_not_equal_with_free(text, expected) \
NB. I known this is probably just following cmocka, but I find it […]
I tried to make it better, dropped _string (7 chars) and replaced free->and (1 char) so in total I removed 8 chars from boilerplate. The remaining stuff seems to be critical: assert and free, both meaningful words, I would keep them.
What do you think?
To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.