Attention is currently required from: Antonio Vázquez Blanco.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    I agree with renaming cli_classic.h to cli_getop.h.
    But there is also one more thing in this patch, changing the license header text, and I don't think it should be in the same commit.

    I actually also agree with using SPDX tags, if we do it for all the source files, it's a great improvement, so much less lines of code. There was even a discussion at some point recently about that, and it's one of the things to do on my list.

    But before starting changing all the headers there are few things I would want to check, and also in any case it would be separate commits.

    So, long story short, would you mind to return back the old license headers, and keep only the renaming cli_classic.h -> cli_getop.h in this commit?
    And I hope that we will do license headers later.

    Thank you!

To view, visit change 84983. To unsubscribe, or for help writing mail filters, visit settings.