Attention is currently required from: Angel Pons, Nikolai Artemiev.

View Change

6 comments:

• File ichspi.c:

  • Patch Set #12, Line 1500: flash->chip->tested = TEST_OK_PREWB;

    What if ich_hwseq_get_flash_id() bailed?

  • Patch Set #12, Line 135: #define HSFC_CYCLE_RDID HSFC_FCYCLE_MASK(6)

    This belongs to PCH100_HSFC_FCYCLE*. It doesn't fit in the 2 bits for ICH9.
    (ICH9_HSFC_FCYCLE_BIT_WIDTH is a mask, not a number of bits, apparently).

  • Patch Set #12, Line 1404: if ((chip->manufacture_id == mfg_id) && (chip->model_id == model_id))

    Should check if it's a SPI flash and if the database numbers are for RDID.

  • Patch Set #12, Line 1466: const int len = sizeof(data);

    Why 4?

  • Patch Set #12, Line 1474: if (ich_exec_sync_hwseq_xfer(flash, HSFC_CYCLE_RDID, 1, len, ich_generation,

    Should check if RDID cycle is supported (since PCH100).

  • Patch Set #12, Line 1494: return -1;

    Does this break normal read/erase/write operation if there is no matching entry?

To view, visit change 69195. To unsubscribe, or for help writing mail filters, visit settings.