Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    Yes, although that would mean including more header files here ... but maybe this is fine? […]

    Just to add one comment, adding tests to code that has not been written with testing in mind is often going to involve refactoring, I think. In general, I suggest doing a 'refactoring' commit to get things in the right place then another commit to add your test (i.e. in that order). I don't think we should be afraid to modify the code as needed for tests.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.