Attention is currently required from: Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, Peter Marheine.

View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 7:

    layout: Introduce layout_next()
    
    Also, a `layout.c` internal version _layout_next() 
    

    Maybe I am missing something, but this sounds like there are two functions: layout_next() and _layou […]

    I added both, the API one uses pointers to const struct romentries
    and the internal one pointers to mutable struct romentries.

    I could just rename the latter to `mutable_layout_next()`, what
    do you think?

• File layout.c:

  • Patch Set #3, Line 44: static struct romentry *_layout_next(

    Looks like this is declared without the leading underscore and used both ways.

    Their signatures differ, see comment thread on the commit message.

To view, visit change 33542. To unsubscribe, or for help writing mail filters, visit settings.