Attention is currently required from: Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 ) Change subject: layout: Introduce layout_next() ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/33542/comment/a1c1f9c8_c6ef867b PS3, Line 7: layout: Introduce layout_next() : : Also, a `layout.c` internal version _layout_next()
Maybe I am missing something, but this sounds like there are two functions: layout_next() and _layou […] I added both, the API one uses pointers to const struct romentries and the internal one pointers to mutable struct romentries.
I could just rename the latter to `mutable_layout_next()`, what do you think? File layout.c: https://review.coreboot.org/c/flashrom/+/33542/comment/2f35d876_5c9d1a66 PS3, Line 44: static struct romentry *_layout_next(
Looks like this is declared without the leading underscore and used both ways. Their signatures differ, see comment thread on the commit message.
-- To view, visit https://review.coreboot.org/c/flashrom/+/33542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa Gerrit-Change-Number: 33542 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Daniel Campello <campello@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Peter Marheine <pmarheine@chromium.org> Gerrit-Comment-Date: Fri, 14 May 2021 15:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org> Gerrit-MessageType: comment