Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Peter Marheine.
5 comments:
Commit Message:
Patch Set #2, Line 7: Avoid internal relying on pacc global
I guess the "internal" programmer was meant.
Yes, "internal" was meant to mean "internal programmer". I added that to the commit message but feel free to adjust if my grammar isn't ideal.
File internal.c:
I guess this just happened to work. We might need `pacc` here too eventually.
ACK, will look into that as a follow up in the pcidev series here. Thanks for pointing it out Nico.
temp = pcidev_scandev(&filter);
if (temp) {
/* Read PCI class */
tmp2 = pci_read_word(temp, 0x0a);
if (tmp2 == devclass)
return temp;
}
The original code would continue walking the linked list of devices if `tmp2 == devclass` is false. […]
Done. Thank you!
temp = pcidev_scandev(&filter);
if (temp) {
if ((card_vendor == pci_read_word(temp, PCI_SUBSYSTEM_VENDOR_ID))
&& (card_device == pci_read_word(temp, PCI_SUBSYSTEM_ID)))
return temp;
}
Same situation as in `pci_dev_find_vendorclass()`, see comment above.
Done.
File pcidev.c:
struct pci_dev *pcidev_scandev(struct pci_filter *filter)
{
struct pci_dev *temp;
for (temp = pacc->devices; temp; temp = temp->next)
if (pci_filter_match(filter, temp))
return temp;
return NULL;
}
To allow resuming searches (see `internal.c` comments), I'd modify this function as follows: […]
Done
To view, visit change 59275. To unsubscribe, or for help writing mail filters, visit settings.