Attention is currently required from: Dmitry Zhadinets, Peter Marheine.
2 comments:
Patchset:
Yeah, It should be merged as soon as possible […]
Yes, I will merge this tomorrow.
I also thought about it on a fresh head in the morning, and what I said as "alternative approach" is actually I think needs to be done too, I made CB:87180 for it.
The default should be, firstly, same as before (existing clients are not shocked),
and secondly, we give clients all messages (don't make decision for them) and then they have choice if they want to lower the log level.
As for our client, cli, I think it also makes sense to set the max log level explicitly. Whatever is the default, cli knows that it wants all messages in the callback.
It's something that I realised only after merging the log level api change, but better later then never :)
Patchset:
Thanks so much everyone for quick reviews!
To view, visit change 87174. To unsubscribe, or for help writing mail filters, visit settings.