Edward O'Callaghan submitted this change.

View Change

Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
Revert "print.c: Dedup 'test_state_to_text()' logic"

This reverts commit 61e16e549a52194ac80ef40504f2dc661d1ff99c.

Obviously throws alignment in the table off and changes output
class from `general` to `programmer` for no visible reason.

Change-Id: I864044b9fac6af9cf6a89c053eccdcb36f17c7bd
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/36909
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M print.c
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/print.c b/print.c
index 596fc53..6a7ff5d 100644
--- a/print.c
+++ b/print.c
@@ -401,7 +401,14 @@
for (i = 0; i < maxboardlen - strlen(b->name); i++)
msg_ginfo(" ");

- msg_pinfo(test_state_to_text(b->working));
+ switch (b->working) {
+ case OK: msg_ginfo("OK "); break;
+ case NT: msg_ginfo("NT "); break;
+ case DEP: msg_ginfo("DEP "); break;
+ case NA: msg_ginfo("N/A "); break;
+ case BAD:
+ default: msg_ginfo("BAD "); break;
+ }

for (e = board_matches; e->vendor_name != NULL; e++) {
if (strcmp(e->vendor_name, b->vendor)

To view, visit change 36909. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I864044b9fac6af9cf6a89c053eccdcb36f17c7bd
Gerrit-Change-Number: 36909
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged