Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

4 comments:

• File layout.c:

  • Patch Set #2, Line 139: || file == NULL

    Yes I forgot that indeed file is optional parameter. […]

    Line 144 causes a memory leak now. If a colon is found but the second parameter (the file name) isn't given, then `name` doesn't get freed because line 144 just returns. That's why I suggested to leave that code where it is and to just extend that if-block, so that we error out early as possible.

    You can either replace that return with `goto error` or you move lines 140-152 below line 131, where they were before. I prefer the latter.

• File layout.c:

  • Patch Set #3, Line 135: if (name == NULL) {

    nit: `!name`

  • Patch Set #3, Line 142: if(!colon[1]) {

    mising space `if (`

  • Patch Set #3, Line 148: if (file == NULL) {

    nit: `!file`

To view, visit change 70006. To unsubscribe, or for help writing mail filters, visit settings.