Attention is currently required from: Nico Huber, Edward O'Callaghan, Samir Ibradžić.
View Change
1 comment:
Patchset:
Patch Set #32:
I wondered what device was used for testing so far and […]
Thanks for your effort!
hm, I´m not sure what´s wrong. Saving a few seconds is not what I was looking for...
Some information:
- the 1,36MHz on the screenshot is wrong (sorry for missleading!!) It´s the distance between the cursors which may be placed arbitrarily
- I´m using default divisor and on my osci screenshots taken last week that results in something between 25-30 MHz (did not measure, but estimate from screenshots)
- lsusb says bcdDevice 7.00 as well
- I run: `make CONFIG_ENABLE_LIBUSB1_PROGRAMMERS=no`. So I´m not using libusb 1.0 maybe this leads to some difference?
- I´m doing tests on my side with an N25Q128..3E chip (has quite the same parameters as W25Q128FV")
- I´m running flashrom on a virutal machine (don´t think this makes any difference)
- at SPI-Bus level the multicmd+chunk4k looks much better and faster (i.e. less bursts) so I have no idea why this should not lead to an overall speed increase... (regardless of the setup)
NB: yepp, I noticed that with the erase block size, as well and have it on my todo list. I was thinking about something like comandline parameter to select block size or an extra parameter at flashchips.c to mark the preferred block size. May be we should open a new patch for that to discuss ideas... (it was just because of lack of support for this patch for month why I did not step further)
To view, visit change 40477. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 32
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Samir Ibradžić <sibradzic@gmail.com>
Gerrit-Comment-Date: Mon, 03 May 2021 07:27:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment