Attention is currently required from: Sam McNally, Angel Pons.
View Change
1 comment:
File i2c_helper_linux.c:
Patch Set #6, Line 42: char *dev = malloc(sizeof(I2C_DEV_PREFIX));
I see. Let me try another approach...
Have you had any interesting ideas?
It seem like the only alternative is to have the caller provide a buffer, which either needs to be large enough that we assume it's always large enough (PATH_MAX?), or provide a function that returns how long the string we want to return is and let the caller allocate enough space. In the latter case we're just moving who does the allocation so it doesn't seem worth adding the complexity of another function.
To view, visit change 52405. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieea57b2445f3aca16c87d8f839dff131009531a0
Gerrit-Change-Number: 52405
Gerrit-PatchSet: 9
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 06:17:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment