Steve Markgraf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43416 ) Change subject: flashchips: Add support for Macronix MX25L5121E ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c File flashchips.c: https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c@8577 PS1, Line 8577: spi_chip_write_256
Yes, I just did some testing with a layout file. […] Done
https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c@8578 PS1, Line 8578: MX25L5121E supports dual I/O
Oops, I thought I removed that. Done
https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c@8579 PS1, Line 8579: 2.35
Same here, 2.7V-3.6V is correct. Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/43416 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I881e2cda938083ba271b2ee0c457d2bbd8e1a766 Gerrit-Change-Number: 43416 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Markgraf <steve@steve-m.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 13 Jul 2020 22:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Steve Markgraf <steve@steve-m.de> Gerrit-MessageType: comment