View Change

1 comment:

• File edi.c:

  • Patch Set #4, Line 162: }

    Thanks for adding this, it's indeed useful to be a bit more verbose than I was initially!

    Naming variables rc1 and rc2 does not feel very consistent with the rest of the code in this file though, so I suggest that you keep using a single rc variable.

    Most importantly, I don't think it makes a lot of sense to print "rc1" and "rc2" in the error string. Instead, I think it would make more sense to print something like "reading EDIID failed" and "reading HWVERSION failed".

    What do you think?

To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.