fixed

7 comments:

File flashchips.h:
- Patch Set #2, Line 858:
```
#define ST_SPI_FAMILY_CODE  0x00
#define ST_M95M02           0x0012 /* ST M95XXX 2Mbit (256KiB) */
```
  Please use tabs for alignment.
  Done
- Patch Set #2, Line 859: 00
  The high byte 00 here is actually the family code. I don't […]
  Done
File spi25.c:
- Patch Set #2, Line 443: static int spi_nbyte_program(struct flashctx *flash, unsigned int addr, const uint8_t *bytes, unsigned int len)
  Moving this function doesn't seem needed anymore?
  Done
File spi95.c:
- Patch Set #2, Line 8: * the Free Software Foundation; version 2 of the License.
  I would prefer new code to be added under […]
  Done
- Patch Set #2, Line 34: uint32_t id1, id2, id3;
  As mentioned in `flashchips.h`, the model id (id2) should include the […]
  Done
- Patch Set #2, Line 43:
```
	id2 = readarr[2]; // model id
	id3 = readarr[1]; // SPI Family code, must be 0x00
```
  Please join these into a single `id2` that is compared against `chip->model_id`.
  Done
- Patch Set #2, Line 61: (uint8_t*) malloc
  Please place space as follows: […]
  Done

To view, visit change 34496. To unsubscribe, or for help writing mail filters, visit settings.