Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #2, Line 54: bp_

    The `bp_` prefix seems unnecessary now.

  • Patch Set #2, Line 167: struct buspirate_spi_data *buspirate_data = data;

    How about an

        unsigned char *const bp_commbuf = buspirate_data.bp_commbuf;

    here and similar cases below? that could reduce some noise, both in code and diff.

To view, visit change 52958. To unsubscribe, or for help writing mail filters, visit settings.