Attention is currently required from: Nico Huber, Edward O'Callaghan, David Hendricks, Angel Pons, Arthur Heymans.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Please mention all changes (and affected paths) in the commit message and argue why they are necessary.

    Code snippet #1:
    > if (content->ISL == 16)
    > return CHIPSET_5_SERIES_IBEX_PEAK;

    Commit message:
    This adds an explicit check for Ibex Peak when guessing chipset from IFD
    contents

    Rationale: This makes it so that we positively identify Ibex Peak, using the ISL value you've confirmed, instead of guessing based on other chipsets not being detected.

    Code snippet #2:
    > /* Ibex Peak is historically used as the default */

    Commit message:
    > adds a comment that Ibex Peak is historically the default when other chipsets are not detected.

    Rationale: This adds some context to explain why we return CHIPSET_5_SERIES_IBEX_PEAK instead of something else, such as CHIPSET_ICH_UNKNOWN. Hopefully some documentation will avoid this sort of friction in the future.

To view, visit change 57580. To unsubscribe, or for help writing mail filters, visit settings.