Attention is currently required from: Nico Huber, Nikolai Artemiev, Anastasia Klimchuk.
3 comments:
Patchset:
You need to explain what have you done in the latest patchset :) I was looking into diffs between PS […]
All changes are side-effects of rebasing onto latest WP patches which now don't support "power cycle" and "permanent" kinds of write protection.
File tests/chip_wp.c:
This is probably because I removed support for setting power cycle / permanent protection in a recen […]
Yes, I just adjusted tests to account for changes in WP implementation.
Patch Set #13, Line 390: /* Protect first 4 KiB. */
The comment has changed to opposite meaning, but range remains the same? Maybe I am missing somethin […]
Thanks, I forgot to update values to match what actually happens. The two ranges are complements of one another and CMP bit is not set here, that's why tests pass either way. The reason CMP isn't set is that it resides in SR2 which is written after SR1 and by that time WP is active and SR2 can't be changed due to hwwp=yes. This is a side-effect of having to specify state of WP pin before configuring WP.
To view, visit change 59075. To unsubscribe, or for help writing mail filters, visit settings.